Skip to content

Conversation

@avivajpeyi
Copy link
Collaborator

@avivajpeyi avivajpeyi commented Dec 10, 2024

  • Updated to latest action versions (e.g., actions/checkout@v4, actions/setup-python@v5)
  • Switched to Ubuntu 22.04
  • Added concurrency to prevent redundant workflow runs
  • Replaced manual Docker login with docker/login-action@v3
  • Use docker/setup-buildx-action@v3 for more efficient builds
  • use docker/build-push-action@v5 for better performance and caching
  • Removed LaTeX-COMPAS action (unused)

@avivajpeyi avivajpeyi changed the title update COMPAS complie workflow with newer versions of actions update COMPAS workflows with newer versions of actions Dec 10, 2024
@avivajpeyi
Copy link
Collaborator Author

avivajpeyi commented Dec 10, 2024

@jeffriley, is the latex-compas-ci even being used? docs/COMPAS_LaTeX does not exist... Should we get rid of this yaml?


Jeff confirmed that it is not being used. Getting rid of it.

@avivajpeyi
Copy link
Collaborator Author

Ah I can't trigger the docker-build from my Fork/branch (don't have the COMPAS credentials)... We'll have to test that from a branch within TEAMCompas/COMPAS

@avivajpeyi avivajpeyi marked this pull request as ready for review December 11, 2024 01:25
@avivajpeyi
Copy link
Collaborator Author

avivajpeyi commented Dec 11, 2024

Im not having much luck with the PR-commenter (yet again).

If the detailedEvol plot (generated in the CI) is indeed useful, we could get the CI to upload the image to the repo.

0: DCO formed: (Main_Sequence_>_0.7 -> Black_Hole) + (Main_Sequence_>_0.7 -> Black_Hole)

detailedEvolutionPlot

This would then be a tracked file and will show up in the git-diff :
https://docs.github.com/en/repositories/working-with-files/using-files/working-with-non-code-files

I'll leave this for a future PR, and would like to hear from @ilyamandel / @jeffriley if this is a feature that might be useful.

@ilyamandel
Copy link
Collaborator

Thank you, @avivajpeyi! I am OK with just testing that we succeed in generating the plot; not critical to be able to review it.

Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the rapid fix, @avivajpeyi !

@ilyamandel ilyamandel merged commit 7b0688c into TeamCOMPAS:dev Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants